Allow for passing of sub document to get one part of a filing - #5
Open
nickderobertis wants to merge 3 commits into
Open
Allow for passing of sub document to get one part of a filing#5nickderobertis wants to merge 3 commits into
nickderobertis wants to merge 3 commits into
Conversation
added 3 commits
August 18, 2019 13:33
Use Filing class in internals and as another interface which can be used to get metadata for the filings
Author
|
I ended up also needing to get some metadata for the filings - e.g. period of report. I created a If you want to merge just a portion of these changes, let me know and I can split them up. |
Owner
|
There seems to be a conflict for this. If you can resolve it, I'll merge this in. Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for putting together this EDGAR tool.
I needed to get just one exhibit from the 10-K, so I added this functionality into the
getDocumentsfunction, but using a keyword argument so that the original usage of the function is unchanged.I tried to set up the xpath generally so that it will work for any exhibit/sub-document type, you just need to pass the name of it and it will do a string match on the Type column.
Usage would be like this:
I hope you'll include this in the main module, I think it could be very useful to others.